grade-school, bowling: Remove unnecessary mut#346
Merged
ijanos merged 2 commits intoexercism:masterfrom Sep 1, 2017
petertseng:no-mut
Merged
grade-school, bowling: Remove unnecessary mut#346ijanos merged 2 commits intoexercism:masterfrom petertseng:no-mut
mut#346ijanos merged 2 commits intoexercism:masterfrom
petertseng:no-mut
Conversation
The `iter_mut` yields mutable references; `frame` does not need to be mutable. Previously, because of rust-lang/rust#30280 this was not considered a warning. The fix is in rust-lang/rust#43582 This means on recently nightlies this warning is emitted.
The `or_insert` already returns a mutable reference; `entry` does not need to be mutable. Previously, because of rust-lang/rust#30280 this was not considered a warning. The fix is in rust-lang/rust#43582 This means on recently nightlies this warning is emitted.
ijanos
approved these changes
Sep 1, 2017
Contributor
ijanos
left a comment
ijanos
left a comment
There was a problem hiding this comment.
your understanding is correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if my understanding of the situation is incorrect and/or I gave an incorrect explanation.