Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades a large number of dependencies across the project. The changes are mostly in Cargo.toml and Cargo.lock files, which is expected for this kind of update. I've reviewed the code changes made to adapt to new APIs, and they seem correct. This includes the switch from doc_auto_cfg to doc_cfg due to Rust toolchain updates, and the adaptation to the new otcrypto_sha2_* API in crates/runner-opentitan/src/crypto/hash.rs following the opentitan submodule update. The update of mdbook and assemblyscript versions are also correctly handled. Overall, this is a solid dependency upgrade.
ia0-review
approved these changes
Oct 3, 2025
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 3, 2025
This was changed by the bump in google#932.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 3, 2025
This was changed by the bump in google#932.
ia0
added a commit
that referenced
this pull request
Oct 3, 2025
This was changed by the bump in #932.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 7, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 7, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 7, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 7, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 8, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 8, 2025
This is a follow-up of google#932.
Merged
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 8, 2025
This is a follow-up of google#932.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Oct 8, 2025
This is a follow-up of google#932.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're holding 2 things behind: