fix(segment): setting value via binding updates button state#28837
Merged
liamdebeasi merged 1 commit intomainfrom Jan 17, 2024
Merged
fix(segment): setting value via binding updates button state#28837liamdebeasi merged 1 commit intomainfrom
liamdebeasi merged 1 commit intomainfrom
Conversation
3 tasks
3 tasks
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 1, 2024
…ms (#29418) Issue number: resolves #29414 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In Angular when the segment buttons are dynamically rendered, the segment will not set the active visual state for the selected segment after the re-render. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - In Angular the segment will set the active item visually when the items are dynamically changed Previously this PR: #28837 aimed to resolve #28816. I have confirmed that the modified approach in the dev-build fixes #29414 and #28816 and the previous change is no longer needed. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev-build: `8.0.2-dev.11714411675.10f48160`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28816
What is the current behavior?
The value is set on Segment asynchronously when binding it in Angular. However, the timing works out such that the value changes after
connectedCallbackis fired but before any Stencil Watchers are configured. As a result, ourvalueproperty watcher does not fire which causesionSelectto not be emitted. Segment Buttons rely on this event to know when to update their state (if the value changes such that a segment button is now selected). This results in a checked segment button not appearing checked.This is similar to other issues that have been fixed:
#28510
#28488
#28526
What is the new behavior?
ionSelectoncomponentDidLoadso that any descendant segment buttons can update correctly.Does this introduce a breaking change?
Other information
Dev build:
7.6.5-dev.11705415448.16878103This is a timing issue with Stencil, so I am unable to write a reliable automated test. Reviewers should test the dev build in the repro provided in the linked issue.