feat(modal): add IonModalToken for injecting modal elements in Angular components#30474
Merged
ShaneK merged 8 commits intofeature-8.7from Jun 23, 2025
Merged
feat(modal): add IonModalToken for injecting modal elements in Angular components#30474ShaneK merged 8 commits intofeature-8.7from
ShaneK merged 8 commits intofeature-8.7from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShaneK
changed the title
thetaPC
requested changes
Jun 17, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
Is it possible to include tests for this? Or at the very least add it to a test page like angular/test/base/src/app/standalone/ and angular/test/base/src/app/lazy/?
Other than that, no issues!
…eating and accessing modals through angular
Member
|
Shouldn't this go into |
brandyscarney
approved these changes
Jun 23, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Great solution! My only feedback is a spelling issue in the tests.
Also my previous comment about changing the branch this targets to feature-8.7 since this is a feature. 👍
packages/angular/test/base/src/app/standalone/home-page/home-page.component.html
Outdated
Show resolved
Hide resolved
packages/angular/test/base/src/app/standalone/programatic-modal/modal/modal.component.html
Show resolved
Hide resolved
...ages/angular/test/base/src/app/standalone/programatic-modal/programatic-modal.component.html
Show resolved
Hide resolved
packages/angular/test/base/src/app/standalone/programatic-modal/programatic-modal.component.ts
Show resolved
Hide resolved
packages/angular/test/base/src/app/standalone/programatic-modal/programatic-modal.component.ts
Outdated
Show resolved
Hide resolved
packages/angular/test/base/src/app/standalone/app-standalone/app.routes.ts
Outdated
Show resolved
Hide resolved
...ges/angular/test/apps/ng19/src/app/standalone/programatic-modal/programatic-modal.service.ts
Outdated
Show resolved
Hide resolved
...s/angular/test/apps/ng19/src/app/standalone/programatic-modal/programatic-modal.component.ts
Outdated
Show resolved
Hide resolved
...s/angular/test/apps/ng19/src/app/standalone/programatic-modal/programatic-modal.component.ts
Outdated
Show resolved
Hide resolved
...s/angular/test/apps/ng19/src/app/standalone/programatic-modal/programatic-modal.component.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
Changed target branch and fixed the spelling of programmatic, thanks! |
brandyscarney
pushed a commit
that referenced
this pull request
Jul 30, 2025
…r components (#30474) Issue number: resolves #internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently, we provide no injection access to angular modals, which makes it difficult to connect to their events normally. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> This is an attempt to allow easier programmatic access to the internals of injected modals. ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `8.6.2-dev.11749830167.1460aa73`
brandyscarney
pushed a commit
that referenced
this pull request
Jul 30, 2025
…r components (#30474) Issue number: resolves #internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently, we provide no injection access to angular modals, which makes it difficult to connect to their events normally. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> This is an attempt to allow easier programmatic access to the internals of injected modals. ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `8.6.2-dev.11749830167.1460aa73`
brandyscarney
pushed a commit
that referenced
this pull request
Jul 30, 2025
…r components (#30474) Issue number: resolves #internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently, we provide no injection access to angular modals, which makes it difficult to connect to their events normally. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> This is an attempt to allow easier programmatic access to the internals of injected modals. ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `8.6.2-dev.11749830167.1460aa73`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #internal
What is the current behavior?
Currently, we provide no injection access to angular modals, which makes it difficult to connect to their events normally.
What is the new behavior?
This is an attempt to allow easier programmatic access to the internals of injected modals.
Does this introduce a breaking change?
Other information
Dev build:
8.6.2-dev.11749830167.1460aa73