fix(header): show iOS condense header when app is in MD mode#30690
Merged
ShaneK merged 5 commits intoionic-team:mainfrom Dec 22, 2025
Merged
fix(header): show iOS condense header when app is in MD mode#30690ShaneK merged 5 commits intoionic-team:mainfrom
ShaneK merged 5 commits intoionic-team:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kumibrr
changed the title
kumibrr
changed the title
ShaneK
changed the title
|
@ShaneK is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Hey @kumibrr! Thanks for this request! I hope you don't mind, I've modified your PR to remove the HTML file as we usually only use them for things that change a lot and we'll be checking on often. I've replaced it with a regression test that uses Hopefully we can get this merged and deployed soon. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29929
What is the current behavior?
When forcing
mode=iosin a collapsible header,.header-collapse-condensewould still be applied from theheader.md.scssfile, leaving the collapsible header always hidden.What is the new behavior?
When forcing
mode=iosin a collapsible header, the.header-collapse-condensestyles from theheader.md.scssfile won't be applied, and the collapsible header will be visible.Does this introduce a breaking change?
Other information
Something worth mentioning is that this behavior only appears after initial load: if the route is loaded refreshing the page, the header will appear and work correctly, but navigating forth and back will apply both the .ios and .md style files.
I showcase this with a modal because It'll always display the broken hehavior.
Screen.Recording.2025-09-23.at.20.00.26.mp4
Screen.Recording.2025-09-23.at.20.03.07.mp4