Fetch support.

[tiennou]

This supersedes #203.

It looks mostly ready so I'm open to suggestions. It misses tests (again :-S) and documentation.

[jspahrsummers]

Style: dot syntax, since these methods don't have externally-visible side effects.

[jspahrsummers]

🍄 Can you please also merge from master?

[tiennou]

🌻

[jspahrsummers]

Yeah, the name isn't right. What about -cancelOperation ? I'm not really against *stop parameters, but the caller of the block ought to still have access to the specific remote under consideration to call it, and I can't really add the *stop parameter to credentialBlock because it won't always be needed.

I don't think the credential block needs a BOOL *stop, but the rest should have one. The remote is still accessible, because any code that could pass in these blocks will also know the GTRemote object, and can just capture it.

[tiennou]

That's more or less what I was saying ;-). I'll add *stop parameters then.

[jspahrsummers]

I don't see anywhere that specifies this will return 1. We should probably compare != 0 instead.

[jspahrsummers]

Thanks! Just a few more notes.

[pbendersky]

I'll work on a few of these comments and commit.

[pbendersky]

@jspahrsummers There are only two changes missing, I'm waiting on your comments on those (options dictionary, which is similar to what we currently have for clone).

[tiennou]

Okay, good to go.

As a bonus, I added a remote clone test against the libgit2 documentation if you set some environment variables — I'm overly cautious around pointer-thingy changes ;-).

[jspahrsummers]

This can use -mutableCopy.

[tiennou]

Yeah, I was so annoyed by the duplication between this and the one above that it just flew above my head 😧.

[jspahrsummers]

This looks really great. Thanks, and sorry for the delay! 🙇