Convert local file: URLs to paths before handing over to git_clone.

[tiennou]

Fixes a bug where a locally-cloned remote would get a file: URL as it's
origin URL, making the push machinery shrivel in fear.

[jspahrsummers]

This second check is redundant. (Reference URLs should return YES for isFileURL.)

[jspahrsummers]

Can you add tests for cloning a file path URL and a file reference URL?

[tiennou]

Added test. And also converted the old ones to the new Expecta-based format. And also also added more methods to GTRepository. And also also wiht fixed documentation. Wait for the intermission ;-).

Can anyone confirm that the old OCUnit-based tests don't run anymore ? After converting the +clone one, it wouldn't work without me changing originURL = self.bareRepositoryFixture.fileURL to originURL = self.bareRepositoryFixture.gitDirectoryURL, and the debugger was nice enough to not stop on the breakpoint I've set in the Test file... Also, if there's a way to restrict which test suits/test cases are ran, I'm listening ;-).

[jspahrsummers]

Can anyone confirm that the old OCUnit-based tests don't run anymore?

No, they do. We should remove any of the old tests that have been converted over.

the debugger was nice enough to not stop on the breakpoint I've set in the Test file

Are you using the Test action? It won't stop if testing as part of a Build action.

Also, if there's a way to restrict which test suits/test cases are ran, I'm listening

See fdescribe, fit, etc. in the Specta README.

[tiennou]

Are you definitive whey you say that they run ? Because I'm sure they don't here (I'm testing with ⌘U, Breakpoints enabled, I've tried to add a bogus STAssertFalse(YES) and it doesn't matter). Travis also seem to agree with me — I can't find any reference to GTRepositoryTest in the log, while GTRepositorySpec shows up as expected.

Thanks for the pointers to Specta, I'll go look.

[jspahrsummers]

Are you definitive whey you say that they run ?

They should if they're added to the test target and not commented out.

[tiennou]

Then there's something going on here... They're in the target, not commented, my Xcode 5.0.1 doesn't run them, and Travis is happy too.

[tiennou]

Rebased because I'm trying to keep things concentrated and the other commits weren't relative to that bug fix. Expect another PR with more shiny new stuff soon ;-).

[jspahrsummers]

@tiennou Is this ready for review? Not entirely sure what the status is, based on your last comment.

[tiennou]

Good for review. This is blocking #292 (and the stuff I'm doing locally afterwards) so I need it ;-).

[jspahrsummers]

It'd be nice to put some of this functionality into GHTestCase, since it's more generally useful than just this spec.

[tiennou]

Point taken (I actually looked there first). But I'll do it another forthcoming PR and update that spec at the same time.

[jspahrsummers]

🍔

[tiennou]

Okay, I'm Not Pleased At All. I just noticed that I've rewritten GTRepostoryTest in both that PR and #292. I'll close this one and cherry-pick its constituent parts to the other instead (nobody likes conflict merges). Sorry for the (slightly) duplicated review effort :-S.

[jspahrsummers]

@tiennou Ha, I didn't notice that either! Whoops. 😟