Conversation
af44e6c to
ad0a3f5
Compare
Member
Author
Merged
Member
|
This is amazingly faster. Nice work! Had one snag when running It looks like checking out the This was due to having an older ZipArchive checkout which left behind the |
Member
Member
Author
|
Yeah, SSZipArchive is a bit weird but we use the files directly. |
Member
Author
|
Will remove the file reference. |
Member
|
Looks like |
Member
Author
|
Updated SSZipArchive |
a2abb8c to
a387dbd
Compare
Member
Author
|
Can't update to 1.1 because it has a lot of warnings. Staying on 1.0.1 but remove the reference to the project. |
Member
|
Sounds good to me! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Updates dependencies to Nimble, Quick and SSZipArchive.
iOS Tests were running super slow (30 minutes total) this was because after every single test case the unzipped fixture repository would be deleted from disk and unzipped again from the 28MB big zip file. This was not an issue on Mac as
unzipsuper fast (apparently) butSSZipArchivecannot quite keep up and so every single iOS test case would take 5-7 seconds to unzip + the time the test needs to run.What I did is just unzip it once and store it in a directory called
clean_repository, the directory is still removed after each test but instead of unzipping again I just copy the desired repository into its place not touching theclean_repository.