Conversation
|
Any specific reason for the change (other that it's new in Xcode 7) ? I find that painful-er to read, and I haven't been able to find what's the current preferred syntax (Apple seems to use the non-underscored variant unless there's wacky pointers-to-pointers). This and this seem to imply that Just my 2 cents, in any case. |
|
The main argument is consistency. It avoids the use of both __nullable, nullable and possibly _Nullable in the same file. Also it says in the blog post that in Xcode 7 __nullable is now just a macro that expands to _Nullable. As to the aesthetic consideration, I agree the property syntax with nullable looks nicer but in the other cases I think the older syntax is not justified and also this is Obj-C we're talking about. Anyway, @phatblat suggested it so I thought it would be a good time to update the syntax. |
|
If you think it is cleaner, I can revert it in the |
|
@alehed Thanks for the PullReuqest. I also don't like it but it seems this is the way to go in Xcode 7 and above. Could you rebase onto master so we can merge this? |
|
Should I leave the ones with |
|
I would go with the new Xcode way and use |
|
Those From the Nullability and Objective-C document linked above, emphasis mine :
|
ceca0f5 to
9e4468b
Compare
4e5f9e9 to
7de377e
Compare
|
Rebased on top of master. |
|
Thanks a lot for your contribution! |
While I'm at it. Also removes some nullability annotations from the implementation files.
Depends on #580 to be merged first.