Merged
Conversation
This was referenced May 29, 2017
Merged
tiennou
approved these changes
Jun 19, 2017
Contributor
tiennou
left a comment
tiennou
left a comment
There was a problem hiding this comment.
LGTM ! I ran that locally, and it seems Travis was happy too, so 👍.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rebased onto master and made the tests compile on Xcode 8.3 with the following trade-offs:
should be built with SSH enabledtest on macOSI think the trade-offs are worth it considering we have a green test suite again.
Closes #599