coreboot-4.11 patches: remove unwanted .orig artifacts #1122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coreboot-4.11 patches: remove unwanted .orig artifacts that seems to be making CircleCI fail in the past days.
EDIT: Not sure what happened there with coreboot 4.11 cache. New CircleCI builds have recreated a new caches (coreboot, all modules cache while reusing musl-cross-make cache) and the problem disappeared.
Heads build system is re-extracting coreboot archives (and coreboot archives alone!?) and reapplies patches on each coreboot build iteration.That might need to change, since creating files from patches is nothing wrong.... But re-extracting archives that were previously validated (.module-version_verify?!) is not really supposed to happen, no is repatching the content of the archives. In the present case, coreboot 4.11 was creating 4 files out of patches/coreboot-4.11/0001-Add-Heads-TPM-measured-boot-support.patch. Two of which were not supposed to exist. CircleCI catched this. But we still may have a problem with the two other valid file created, which if patch is reapplied, will still exist in cache passed from one board build to another...CircleCI optimizes building time by providing cache mechanisms and forces its users to build a target under an hour.
This is to force Open Source projects (free tier) to not be leechers of the free tier.
Hopefully, this is CircleCI having a maximum of 3 automatically entered input (it fails on the 3rd)... And this fix will permit src/security/tpm/sha1.c and src/security/tpm/sha1.h to be skipped if existing. Below, we see that CircleCI fills patch prompts with EOF 2 times, and then waits for input on third prompt and then timeouts.Here is the failing log trace from https://app.circleci.com/pipelines/github/tlaurion/heads/990/workflows/f2a430fd-dc8c-4e95-abe3-364a0e825533/jobs/4914/parallel-runs/0/steps/0-103:
Exerpt of that log: