Remove unused LXSS_DISTRO_FLAGS_WSLCORE_MODE#13603
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused LXSS_DISTRO_FLAGS_WSLCORE_MODE flag and its associated code path from the WSL service. The flag was previously defined but no longer serves a purpose in the codebase.
Key Changes
- Removed
LXSS_DISTRO_FLAGS_WSLCORE_MODEconstant definition - Updated
LXSS_DISTRO_FLAGS_ALLto exclude the removed flag - Removed the early return logic in
WslCoreInstance::Initialize()that checked for this flag
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/windows/service/inc/wslservice.idl | Removed flag definition and updated aggregate flag constant |
| src/windows/service/exe/WslCoreInstance.cpp | Removed conditional early return that checked for the unused flag |
benhillis
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed