cleanup: remove invalid m_deviceHostSupport checks#13787
Merged
Conversation
benhillis
requested review from
Brian-Perkins,
OneBlue,
Copilot,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up unnecessary null checks for the m_deviceHostSupport member variable in GuestDeviceManager. Since this variable is initialized in the constructor using wil::MakeOrThrow<DeviceHostProxy>(), which throws on failure rather than returning nullptr, the object is guaranteed to be valid for the lifetime of the GuestDeviceManager instance.
- Removes defensive
THROW_HR_IF(E_NOT_VALID_STATE, !m_deviceHostSupport)checks from three methods - Simplifies
Shutdown()by removing conditional check and directly calling the method
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Brian-Perkins
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This member variable is always guaranteed to be set (because it is set in the constructor).