fix: use platform preferred case in launcher#1449
Merged
connor4312 merged 1 commit intomicrosoft:mainfrom Nov 18, 2022
Merged
Conversation
Launching NodeJS processes on Windows requires us to handle casing of drive letters carefully because NodeJS is case sensitive. The already existing utility function `urlUtils.platformPathToPreferredCase()` is used to adjust paths of the executable and the current working directory. Fixes microsoft#1448 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
Contributor
Author
|
@microsoft-github-policy-service agree [company="EclipseSource"] |
Contributor
Author
|
@microsoft-github-policy-service agree company="EclipseSource" |
Member
|
lgtm, thanks! |
connor4312
approved these changes
Nov 18, 2022
lramos15
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launching NodeJS processes on Windows requires us to handle casing of drive letters carefully because NodeJS is case sensitive.
The already existing utility function
urlUtils.platformPathToPreferredCase()is used to adjust paths of the executable and the current working directory.Fixes #1448
Contributed on behalf of STMicroelectronics
Signed-off-by: Olaf Lessenich olessenich@eclipsesource.com