Update bootstrap-node.js to check for Array.isArray#165289
Merged
alexdima merged 2 commits intomicrosoft:mainfrom Nov 7, 2022
Merged
Update bootstrap-node.js to check for Array.isArray#165289alexdima merged 2 commits intomicrosoft:mainfrom
alexdima merged 2 commits intomicrosoft:mainfrom
Conversation
alexdima
approved these changes
Nov 4, 2022
sandy081
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #165288
As mentioned in the issue, we're seeing
on the console at startup in our fork. Adding the Array.isArray() check resolves this issue from throwing the exception. It is also noted that this check is done in a similar block within bootstrap.js so this diff mimics that behavior.