Skip to content

Add option for smartSelect to ignore subwords#182571

Merged
jrieken merged 1 commit intomicrosoft:mainfrom
russelldavis:smartSelectSubwordsOption
Jun 20, 2023
Merged

Add option for smartSelect to ignore subwords#182571
jrieken merged 1 commit intomicrosoft:mainfrom
russelldavis:smartSelectSubwordsOption

Conversation

@russelldavis
Copy link
Contributor

Fixes #97257

This brings VS Code to parity with other major editors/IDEs (e.g., JetBrains IDEs have the Use "CamelHumps" words option).

@jrieken jrieken added this to the June 2023 milestone May 16, 2023
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @russelldavis!

@jrieken jrieken enabled auto-merge June 20, 2023 10:00
@jrieken jrieken closed this Jun 20, 2023
auto-merge was automatically disabled June 20, 2023 12:16

Pull request was closed

@jrieken jrieken reopened this Jun 20, 2023
@jrieken jrieken merged commit 66ee561 into microsoft:main Jun 20, 2023
smithmum pushed a commit to smithmum/vscode that referenced this pull request Jun 20, 2023
…ordsOption

Add option for smartSelect to ignore subwords
@ArturoDent
Copy link

@jrieken

This new setting doesn't seem to work for words like foo-bar. I see there is this test:

		await assertRanges(new WordSelectionRangeProvider(false), 'f|oo-Ba',
			new Range(1, 1, 1, 7),
			new Range(1, 1, 1, 7),
		);

but it doesn't work for me. The other two cases fooBar and foo_bar do work though.

Also, should the word.separators setting have any effect on the result?

@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: option for smartSelect to ignore subwords

4 participants