Fix #185858: Add option to enable/disable editor group maximization on double clicking tab title#185966
Merged
bpasero merged 2 commits intomicrosoft:mainfrom Jun 26, 2023
Merged
Fix #185858: Add option to enable/disable editor group maximization on double clicking tab title#185966bpasero merged 2 commits intomicrosoft:mainfrom
bpasero merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
|
For the naming "toggleGroupMaximizationOnDoubleClick", I might suggest "toggleGroupMaximizationOnDoubleClickingTab" |
Contributor
Author
|
@starball5 Fair enough. I've changed the naming. |
bpasero
requested changes
Jun 25, 2023
Member
There was a problem hiding this comment.
LGTM but maybe the setting name could be renamed. Now it is toggleGroupMaximizationOnDoubleClickingTab, other settings tend to put the action first, also the command is called "Toggle Editor Group Sizes" so maybe doubleClickTabToToggleEditorGroupSizes?
Contributor
Author
|
@bpasero Sure. I fixed it. |
bpasero
approved these changes
Jun 26, 2023
alexr00
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #185858. It adds an option to enable or disable the behavior that double clicking a tab's title would maximize the current editor group.