Crash on caling Score.undo() in the console

[thibaudk]

It seems to only be missing a caUndo check.

Adding this in src/plugins/score-plugin-js/JS/Qml/EditContext.cpp fixes it

void EditJsContext::undo()
{
  auto doc = ctx();
  if(!doc)
    return;

  auto& s{doc->document.commandStack()};
  if (s.canUndo()) s.undo(); 
}

It would be a quick fix, butt maybe I am missing something.

[jcelerier]

yep please make a PR!

[jcelerier]

likewise redo() certainly needs canRedo()

[thibaudk]

Should the check then happen inside the undo and redo function of the commandStack directly ?

[thibaudk]

Editing the commandStack.hpp like this:

  void undo()
  {
    if (!canUndo()) return;
    undoQuiet();
    localUndo();
  }
  W_INVOKABLE(undo)

  void redo()
  {
    if (!canRedo()) return;
    redoQuiet();
    localRedo();
  }
  W_INVOKABLE(redo)

That would be better, right ?

[jcelerier]

In those I'd rather have

SCORE_ASSERT(canUndo());
SCORE_ASSERT(canRedo());

and keep the if check in

void EditJsContext::undo()

the reason is - the core parts of the software should really enforce "no improper API use" ; while the "external layer" (scripting, etc.) should instead be the overly defensive one to prevent bad user input.