Always return originally passed choice for Choice() #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
reviewed
Sep 26, 2019
Contributor
sirosen
left a comment
sirosen
left a comment
There was a problem hiding this comment.
I'm sorry that this took me so long to circle back to and review. I got pulled into other projects (after we spent good effort discussing this behavior, that feels like a waste).
I think this is the right thing to do. Even after a while away from it, reading it makes sense and is pretty reasonable.
I'd like to merge, but before I do, I had one comment about lower vs casefold. Let me know what you think about that.
sirosen
force-pushed
the
1277-altendky-return_exact_from_choice_insensitive
branch
from
4f76c57 to
89e74e8
Compare
Contributor
|
Just to keep the history a little bit clean, I rebased this before merging. (It's my own fault for taking months to review it.) |
altendky
deleted the
1277-altendky-return_exact_from_choice_insensitive
branch
This was referenced Sep 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1277
replaces #1278