fix overline and italic styles #2058
Merged
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jap
force-pushed
the
improve-copy-paste
branch
from
447eafb to
e1a08c3
Compare
Member
|
Thanks for fixing this. However, in the future, please do "go through the paperwork", such as describing what you're fixing, in both the title and body of the PR message. The way you've worded this PR is really dismissive of maintainers time, which is not appreciated. Keep this in mind for any PRs you make, not only on Pallets projects. |
davidism
changed the title
davidism
changed the title
It looks like the code related to `underline` was copy-pasted, and not all the escape codes got put in correctly.
davidism
force-pushed
the
improve-copy-paste
branch
from
e1a08c3 to
cf3b138
Compare
Member
|
Rebased to 8.0.x since this is a bug fix. Added a changelog entry so users are aware that an issue with styles was addressed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original message: This is a drive-by-commit fixing an obvious error. Please don't force me to go through paperwork.
Maintainer added description: Overline and italic styles were looking at the
underlineargument by mistake.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.