[DOC]: params & units guidelines in contributing page#2248
Merged
kandersolar merged 15 commits intopvlib:mainfrom Dec 10, 2024
Merged
[DOC]: params & units guidelines in contributing page#2248kandersolar merged 15 commits intopvlib:mainfrom
kandersolar merged 15 commits intopvlib:mainfrom
Conversation
echedey-ls
changed the title
RDaxini
reviewed
Oct 9, 2024
Member
RDaxini
left a comment
RDaxini
left a comment
There was a problem hiding this comment.
Nice job. Couple of suggestions + one point about the link to the variables page
Co-Authored-By: RDaxini <143435106+RDaxini@users.noreply.github.com>
8 tasks
RDaxini
reviewed
Nov 27, 2024
Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
Member
Author
|
Ready for review (thx Dax for reminding me xD). Preview linked in PR body. |
AdamRJensen
requested changes
Nov 28, 2024
Member
AdamRJensen
left a comment
AdamRJensen
left a comment
There was a problem hiding this comment.
What a great addition this will be 🥳
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Member
Author
|
Whatsme added!! |
AdamRJensen
approved these changes
Dec 10, 2024
Member
AdamRJensen
left a comment
AdamRJensen
left a comment
There was a problem hiding this comment.
Awesome contribution @echedey-ls 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve "contributing" guidelines on how to find parameter names and their units.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.In coordination with style decided in #2234.
Makes two changes to index pages of functions, to avoid being too verbose and a typo.
Links