Fix typos in ModelChain error messages#2492
Merged
kandersolar merged 4 commits intopvlib:mainfrom Jul 1, 2025
Merged
Conversation
Member
Author
|
Aside: changing the error messages did not fail the tests. Are we missing some test coverage here, or is this okay? |
Member
For For |
kandersolar
reviewed
Jul 1, 2025
cwhanse
approved these changes
Jul 1, 2025
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Member
Author
Makes sense. Unless anyone objects, I'll open a PR later to add a quick test for the |
Member
|
Thanks @RDaxini |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.