Skip to content

allow Pathlib.path objects to be used with Context.cd() #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fndari wants to merge 3 commits into from
Closed

allow Pathlib.path objects to be used with Context.cd() #583

fndari wants to merge 3 commits into from

Conversation

@fndari
Copy link
Contributor

@fndari fndari commented Sep 25, 2018

This addresses #454, implementing the simplest cast-to-str solution as originally suggested by @brutus, plus a basic unit test.

@fndari fndari mentioned this pull request Sep 25, 2018
Closed
@fndari fndari mentioned this pull request Sep 26, 2018
Closed
@florisla florisla mentioned this pull request Jan 6, 2019
Merged
@florisla florisla mentioned this pull request Aug 21, 2019
Closed
@bitprophet
Copy link
Member

bitprophet commented Dec 31, 2020

Rolling into #607

@bitprophet bitprophet closed this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@yajo yajo yajo approved these changes

@krupan krupan krupan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fndari @bitprophet @yajo @krupan