Make Context.cd() accept Path objects #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on this PR? Run into #577 today. |
Rather than reverting to a regular str path, which is already covered by other tests.
florisla
force-pushed
the
454-context-cd-with-path-object
branch
from
ae95728 to
83cc422
Compare
Contributor
Author
|
Rebased on master. |
|
Would be really nice to get this merged. @bitprophet ? |
This was referenced Dec 31, 2020
bitprophet
added a commit
that referenced
this pull request
Dec 31, 2020
Test didn't need to use Path objects; only needs to test the contract being defined.
Member
|
Out in 1.5! |
Contributor
Author
|
Hi,
Are you referring to the 'network' view on GitHub?
That's probably due to the changes being merged into an integration branch
first (named 607-int).
So for the master branch, what's being merged is 607-int, not directly
florisla:454-context-cd-with-path-object
<https://github.com/florisla/invoke/tree/454-context-cd-with-path-object> .
But if you follow the merge commit, you'll still find the original commits.
54b28be
This commit has two parents.
Regards
Floris
Op do 31 dec. 2020 06:48 schreef Russ <[email protected]>:
… How is it that the PR says it was merged, yet only commits authored by
@bitprophet <https://github.com/bitprophet> appear in the git log? Is
this a feature of github?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#607 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANKFIH6CVKPNZXZ4EGQ7U3SXQGCPANCNFSM4GOKO3JQ>
.
|
|
Hi @florisla. Thanks, I worked this out soon after I posted it and deleted the comment. Thanks regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase (with minor modifications) of #583.
The original 583 stalled on AppVeyor, but that is disabled now so this should pass CI.
Closes #583 - original PR
Closes #681 - more recent but similar PR
Fixes #454 - original issue
Fixes #577 - duplicate issue
Fixes #658 - duplicate issue