-
Notifications
You must be signed in to change notification settings - Fork 384
Printing first line of task's docsting by --list #105 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
invoke/cli.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest adding an lstrip() there (e.g. "... + docstring.lstrip().split('\n')[0]") to support docstrings that start on the line after the quotes.
Thanks for @rread to suggest this.
|
@rread Thanks! I fixed it just now. |
|
When a submodule has a default task, the denotation of that task causes a bug in the formatting of that output. |
|
@jthigpen Thank you. You are completely right. I will fix it as soon as I can!. It seems this bug caused by a task with some aliases, not only the case of 'default task'. |
Thanks @jthigpen for pointing it out.
|
👍 |
|
This pull-request still can be merged with master safely. |
|
Thanks a bunch! Very useful change :) Merged this in, rejiggered a bunch of it (there was existing code to handle this display format so I used that), added changelog, and seems to all work now. Just pushed. |
|
Im glad, thanks a lot. |
Supported issue #105.
I also added a test but I'm not similar with the testing tool 'spec'.
So that, please teach me about it of fix the code If you don't like the addition.