Add missing __deepcopy__ to Call class #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having __getattr__ without __deepcopy__ causes infinite recursion in Python 3 when you deepcopy that object. A test is also updated to cause the error fixed in this commit. Fixes pyinvoke#257 Signed-off-by: Máté Farkas <[email protected]>
Contributor
Author
|
When will you release it? Now pyinvoke is broken with Python 3 if you use parameterized pre tasks... |
Member
|
Can't give any concrete estimates, sorry. Soonish™. Given this is pretty small I may just bump it up to 0.12 which is due out Very Soon™. |
Contributor
Author
|
Okay, thank you. It is more than nothing. 😄 |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #257.
(Having
__getattr__without__deepcopy__causes infinite recursion in Python 3 when you deepcopy that object. A test is also updated to cause the error fixed in this commit.)(See for example http://www.peterbe.com/plog/must__deepcopy__)