Fix Context.cd and .prefix behaviour on exception #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When exception happens inside with statement it's escalated to the contextmanager from with statement. By placing `self.command_cwds.pop()' in finally block we make sure command prefixes are handled correctly on exceptions in user code.
|
+1 |
Member
|
Thanks for this, #557 beat you to the |
|
Great that this have been fixed. When can expect it to be merged and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exception happens inside with statement it's escalated to the
contextmanager from with statement. By placing `self.command_cwds.pop()'
in finally block we make sure command prefixes are handled correctly on
exceptions in user code.