Modernize CI #574
Merged
Modernize CI #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump versions, remove unused lines, test Python 3.11.
pquentin
requested review from
VincentVanlaer,
bluetech,
hramezani and
sethmlarson
sethmlarson
approved these changes
Apr 17, 2023
| if-no-files-found: error | ||
|
|
||
| coverage: | ||
| if: always() |
Member
Author
There was a problem hiding this comment.
Yes! I even plan to add it to urllib3 if you agree. This ensures that the coverage step runs even if some jobs failed (but still waiting for everything to finish).
In urllib3 sometimes one single job fails because of a flaky test and we have no idea if coverage is still at 100% or not. The test suite will still be failing, but that way we don't need to wait for everything to pass to know if coverage is still at 100%. It will also cover the case when as admins we just merge a change even if unrelated tests are failing: we have merged uncovered code in the past like that.
There was a problem hiding this comment.
Ooooo I love that!! TIL! Thanks Quentin!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock #563, this pull request does three main things:
I wished I did not have to do everything at once but the codecov uploader was removed, forcing our hand.