Multicharacter replacements in PyUnicode_TranslateCharmap

[doerwalter]

BPO	403100
Nosy	@malemburg, @tim-one, @doerwalter
Files	None: None

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2002-09-04.20:37:11.000>
created_at = <Date 2001-01-04.17:50:43.000>
labels = ['type-feature']
title = 'Multicharacter replacements in PyUnicode_TranslateCharmap'
updated_at = <Date 2002-09-04.20:37:11.000>
user = 'https://github.com/doerwalter'

bugs.python.org fields:

activity = <Date 2002-09-04.20:37:11.000>
actor = 'doerwalter'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['None']
creation = <Date 2001-01-04.17:50:43.000>
creator = 'doerwalter'
dependencies = []
files = ['8183']
hgrepos = []
issue_num = 403100
keywords = []
message_count = 9.0
messages = ['53079', '53080', '53081', '53082', '53083', '53084', '53085', '53086', '53087']
nosy_count = 4.0
nosy_names = ['lemburg', 'tim.peters', 'nobody', 'doerwalter']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue403100'
versions = []

[doerwalter]

This patch modifies Objects/unicodeobject.c/PyUnicode_TranslateCharmap,
so that the error

PyErr_SetString(PyExc_NotImplementedError,
"1-n mappings are currently not implemented");

no longer occurs. I.e.

u"ab".translate({ord(u"a"): u"bbb", ord(u"b"): u"aaa"})

now works. It does this by exponentially
reallocating the string, when there is no more
available space.

[nobody]

I like the idea, but the implementation needs some reworking:
the common case is 1-1 mapping so this should be as fast
as possible; extra size checks slow things down too much.

You can take a different approach, though:
leave things as they are and only add a special case for the 1-n
which does resizing depending on how many extra chars are inserted.
Then as final step, if resizing occurred, call _PyUnicode_Resize()
to cut down the allocate buffer to its true size.

-- Marc-Andre

[doerwalter]

The problem, that you can't know beforehand how long
the result string will be, i.e. if there really will be any 1-n
replacements happening.

It would be possible to do a loop through the replacement
strings and see if there are any that are longer than one character,
but even if there are, you don't know if they will really be used.

So you have three choices:
(1) You either guess how much space you need and reallocate
when the space is not enough or
(2) you do a dry run of the algorithm once and count how much
space you need and do the algorithm a second time and this
time use the strings.
(3) you can keep the strings in a list and join the list into
one string in the end.

For the case of 1-1 mapping the following will happen:

(1) The first allocation has exactly the right amount of space,
there won't be any reallocations, but a size check for every
character will be don (which should be only a few assembler instructions).
The mapping will have to be accessed for every character
in the source string once.

(2) There will only be one allocation, but for every character in
the source string, the mapping has to be accessed twice, which
are calls to Python function, exception handling etc.

(3) You have to make as many memory allocations are are parts
of the final string that you create, including error handling etc.

I think (1) is clearly the fastest method.

[nobody]

I'll checkin a patch for this tomorrow which implements what I had
in mind. The patch doesn't change the performance of the charmap
codec.

Thanks,
-- Marc-Andre

[malemburg]

Checked in a different patch providing the same functionality.
Please see the CVS checking message for details.

[doerwalter]

Logged In: YES
user_id=89016

The patch that was checked in changes
PyUnicode_DecodeCharmap and PyUnicode_EncodeCharmap, but
not PyUnicode_TranslateCharmap, where this functionality is
also useful. . (e.g. for
u"<foo>".translate({ord("<"): u"<", ord(">"): u">"})
)

[malemburg]

Logged In: YES
user_id=38388

Reopened. This should really be marked as feature request
but for some reason SF won't let me change the Data Type.

[tim-one]

Logged In: YES
user_id=31435

Changed to Feature Requests, at MvL's request.

[doerwalter]

Logged In: YES
user_id=89016

This is implemented by the PEP-293 patch. Closing the
request.