gh-108494: Argument Clinic: fix option group for Limited C API#108574
Merged
vstinner merged 2 commits intopython:mainfrom Aug 29, 2023
Merged
gh-108494: Argument Clinic: fix option group for Limited C API#108574vstinner merged 2 commits intopython:mainfrom
vstinner merged 2 commits intopython:mainfrom
Conversation
Use PyTuple_Size() instead of PyTuple_GET_SIZE().
Member
Author
|
Issue found while converting syslog to the limited C API. |
AlexWaygood
reviewed
Aug 28, 2023
AA-Turner
reviewed
Aug 28, 2023
Comment on lines
+1718
to
+1721
| nargs = 'PyTuple_Size(args)' | ||
| else: | ||
| nargs = 'PyTuple_GET_SIZE(args)' | ||
| add(f"switch ({nargs}) {{\n") |
Member
There was a problem hiding this comment.
Style suggestion -- because of the f-strings needing the duplication of {, perhaps just being explicit in both cases would be worth it?
Suggested change
| nargs = 'PyTuple_Size(args)' | |
| else: | |
| nargs = 'PyTuple_GET_SIZE(args)' | |
| add(f"switch ({nargs}) {{\n") | |
| add("switch (PyTuple_Size(args)) {\n") | |
| else: | |
| add("switch (PyTuple_GET_SIZE(args)) {\n") |
erlend-aasland
approved these changes
Aug 29, 2023
AlexWaygood
approved these changes
Aug 29, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM, other than @AA-Turner's style nit, which I agree with :)
Member
Author
|
Merged, thanks for reviews. I prefer to avoid repetition even if the f-string is just a little bit surprising. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use PyTuple_Size() instead of PyTuple_GET_SIZE().