gh-112984: Fix link error on free-threaded Windows build#114455
gh-112984: Fix link error on free-threaded Windows build#114455zooba merged 1 commit intopython:mainfrom
Conversation
The test_peg_generator test tried to link the python313_d.lib library, which failed because the library is now named python313t_d.lib. The underlying problem is that the "compiler" attribute was not set when we call get_libraries() from distutils.
|
!buildbot nogil |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit ccfc91b 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
cc @itamaro |
|
The relevant piece of distutils is this code: The |
|
We might also want to fix the library name upstream in distutils for the free-threaded build on non-MSVC compilers. |
itamaro
left a comment
itamaro
left a comment
There was a problem hiding this comment.
thanks for the quick fix, Sam!
is this test not covered by the free-threaded CI? only buildbot?
|
Yes, |
|
the buildot is green on this PR (https://buildbot.python.org/all/#/builders/1295/builds/26) |
|
LGTM |
|
Thanks @zooba - would you please merge this PR? |
…nGH-114455) The test_peg_generator test tried to link the python313_d.lib library, which failed because the library is now named python313t_d.lib. The underlying problem is that the "compiler" attribute was not set when we call get_libraries() from distutils.
…nGH-114455) The test_peg_generator test tried to link the python313_d.lib library, which failed because the library is now named python313t_d.lib. The underlying problem is that the "compiler" attribute was not set when we call get_libraries() from distutils.
4 participants
The test_peg_generator test tried to link the python313_d.lib library, which failed because the library is now named python313t_d.lib. The underlying problem is that the cmd.compiler attribute was not set when we call get_libraries() from distutils.