bpo-16970: Adding error message for invalid args #14844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmblweed
changed the title
tmblweed
changed the title
tmblweed
changed the title
gvanrossum
changed the title
Member
|
@gvanrossum Please review. |
gvanrossum
approved these changes
Jul 31, 2019
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
To be clear, most of this is from the original patch on bpo by Robert Leenders (apparently abandoned due to lack of code review years ago). I find the tests a little over-engineered but not enough so to request changes. Thanks for powering through this, @tmblweed!
Member
|
I'll wait ~24 hours to see if other core devs want to chime in, then I'll merge it. |
Contributor
|
Thanks @tmblweed for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-15074 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 2, 2019
BPO -16970: Adding error message for invalid args Applied the patch argparse-v2 patch issue 16970, ran patch check and the test suite, test_argparse with 0 errors https://bugs.python.org/issue16970 (cherry picked from commit 4b3e975) Co-authored-by: tmblweed <[email protected]>
Contributor
|
Sorry, @tmblweed, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Aug 2, 2019
BPO -16970: Adding error message for invalid args Applied the patch argparse-v2 patch issue 16970, ran patch check and the test suite, test_argparse with 0 errors https://bugs.python.org/issue16970 (cherry picked from commit 4b3e975) Co-authored-by: tmblweed <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
BPO -16970: Adding error message for invalid args Applied the patch argparse-v2 patch issue 16970, ran patch check and the test suite, test_argparse with 0 errors https://bugs.python.org/issue16970
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
BPO -16970: Adding error message for invalid args Applied the patch argparse-v2 patch issue 16970, ran patch check and the test suite, test_argparse with 0 errors https://bugs.python.org/issue16970
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
BPO -16970: Adding error message for invalid args Applied the patch argparse-v2 patch issue 16970, ran patch check and the test suite, test_argparse with 0 errors https://bugs.python.org/issue16970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BPO -16970: Adding error message for invalid args
Applied the patch argparse-v2 patch issue 16970, ran patch check and the test suite, test_argparse with 0 errors
https://bugs.python.org/issue16970
Automerge-Triggered-By: @gvanrossum