bpo-39937: modify iter() suggestion to Element.iter()#18937
bpo-39937: modify iter() suggestion to Element.iter()#18937tirkarthi merged 6 commits intopython:masterfrom kumiDa:master
Conversation
In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator() through bpo-36543, it is suggested to use iter() instead. Ideally there should be a suggestion to use Element.iter() instead. The commits does the above modification.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: @rahul-kumi For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
kumiDa
changed the title
kumiDa
changed the title
In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator() through bpo-36543, it is suggested to use iter() instead. Ideally there should be a suggestion to use Element.iter() instead. The commits does the above modification.
|
NEWS entry is not needed. Please remove it. |
|
@serhiy-storchaka It will be helpful to have your review in this since it caused some confusion over builtin function |
|
This change is for 3.9 in whatsnew. I think backport to 3.8 is not needed. |
|
Thanks @serhiy-storchaka for the review. Congratulations @rahul-kumi on your first patch :) |
Thank you @tirkarthi and @serhiy-storchaka ! |
5 participants
In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator()
through bpo-36543, it is suggested to use iter() instead.
Ideally there should be a suggestion to use Element.iter() instead.
The commits does the above modification.
https://bugs.python.org/issue39937