bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objects#26677
bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objects#26677markshannon merged 2 commits intopython:mainfrom
Conversation
isidentical
changed the title
isidentical
force-pushed
the
bpo-44313
branch
4 times, most recently
from
86f2a4d to
c7c708c
Compare
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Great. Just two very minor issues.
Misc/NEWS.d/next/Core and Builtins/2021-06-10-16-10-39.bpo-44313.34RjI8.rst
Outdated
Show resolved
Hide resolved
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Looks good now.
Sorry I missed your update, so importlib needs updating again.
|
Okay will regenerate them tomorrow. |
isidentical
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @isidentical for commit ab1b6c1 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Thanks. |
| # Python 3.11a1 3455 (add MAKE_CELL bpo-43693) | ||
| # Python 3.11a1 3456 (interleave cell args bpo-43693) | ||
| # Python 3.11a1 3457 (Change localsplus to a bytes object bpo-43693) | ||
| # Python 3.11a1 3458 (imported objects now don't use LOAD_METHOD/CALL_METHOD) |
There was a problem hiding this comment.
Shouldn't the actual number be bumped below? I don't think it matters much in this case, but for the sake of consistency/clarity for the next bump, it might be good to fix.
There was a problem hiding this comment.
Right, probably got away during rebase. Will fix
6 participants
https://bugs.python.org/issue44313