bpo-45220: Remove invalid include from resource definition files on Windows#29396
Merged
zooba merged 1 commit intopython:mainfrom Nov 4, 2021
Merged
bpo-45220: Remove invalid include from resource definition files on Windows#29396zooba merged 1 commit intopython:mainfrom
zooba merged 1 commit intopython:mainfrom
Conversation
zooba
added
skip news
needs backport to 3.9
needs backport to 3.10
zooba
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Contributor
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Contributor
|
Sorry @zooba, I had trouble checking out the |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 4, 2021
…indows (pythonGH-29396) (cherry picked from commit fd0c84d) Co-authored-by: Steve Dower <steve.dower@python.org>
|
GH-29405 is a backport of this pull request to the 3.9 branch. |
zooba
added
needs backport to 3.10
Contributor
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 4, 2021
…indows (pythonGH-29396) (cherry picked from commit fd0c84d) Co-authored-by: Steve Dower <steve.dower@python.org>
|
GH-29406 is a backport of this pull request to the 3.10 branch. |
ambv
pushed a commit
that referenced
this pull request
Nov 4, 2021
Contributor
|
This change caused the Windows 11 builder to start failing. I'll wage the change to python.props is the culprit here (allowing Windows 11 SDK) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45220