gh-93370 : Deprecate sqlite3.version and sqlite3.version_info

[rawwar]

removed sqlite3.version and sqlite3.version_info

[ghost]

All commit authors signed the Contributor License Agreement.

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[rawwar]

closes #93370

[rawwar]

I think what I did is wrong. I should be deprecating instead of removing in current version. But, after thinking about how to deprecate sqlite3.version_info and sqlite3.version I don't understand how exactly I can do this. I saw several other deprecation PR's and all of them are either methods or class attributes. That makes it easy to raise a deprecation warning. But, here, version comes from _sqlite as a string constant. Not exactly sure how to display warning when calling an variable.

[AlexWaygood]

Not exactly sure how to display warning when calling an variable.

Take a look at https://peps.python.org/pep-0562/

Example usage for a DeprecationWarning:

cpython/Lib/io.py

Line 60 in 9b12b1b

def __getattr__(name):

[rawwar]

@AlexWaygood , can you please check my usage of __getattr__

[rawwar]

@AlexWaygood , Thank you so much for your feedback. I've incorporated your feedback

[AlexWaygood]

Thanks! This is starting to look pretty good. However, it's still missing:

• Tests
• Updates to the documentation

Could you add those, please? 🙂 Take a look at #23064 as an example of a previous PR deprecating features — it should make clear the kinds of changes that you need to make to the test files and the docs.

Since this is your first contribution to CPython, you're also very welcome to add your name to https://github.com/python/cpython/blob/main/Misc/ACKS if you want to, though that isn't compulsory!

[AA-Turner]

Some minor comments. As Alex said, you still need tests and to update the documentation.

A

[AA-Turner]

Thanks for your work @rawwar!

A

[AlexWaygood]

Some documentation nits :)

Also, if you wanted to be super-thorough, you could also test that these also cause DeprecationWarning to be emitted:

from sqlite import version
from sqlite import version_info
from sqlite.dbapi2 import version
from sqlite.dbapi2 import version_info

[AA-Turner]

The line length of the tests is over 100 -- my suggestion doesn't bring it under 80, but makes it less egregious.

A

[AlexWaygood]

Thanks!

[erlend-aasland]

Looks good.

We haven't added warnings to sqlite3.dbapi2 before, only sqlite3 attributes, but it is ok; it will only stay for two versions :)

Also, I would probably have used subTest instead of spelling each test out.

[erlend-aasland]

Thanks for reviewing everyone, and thanks for the PR, Kalyan! I'm going to merge this as soon as the CI is green.