Skip to content

Translate conditional rendering#421

Merged
alioguzhan merged 6 commits intoreactjs:mainfrom
serkanisyapan:translate-conditional-rendering
May 3, 2023
Merged

Translate conditional rendering#421
alioguzhan merged 6 commits intoreactjs:mainfrom
serkanisyapan:translate-conditional-rendering

Conversation

@serkanisyapan
Copy link
Contributor

@serkanisyapan serkanisyapan commented May 2, 2023

Translate Conditional Rendering page.

@serkanisyapan
Copy link
Contributor Author

serkanisyapan commented May 2, 2023

Bileşen isimlerini Türkçe'ye çevirmedim ama çeviriyorsak onları ekleyebilirim. Rendering Lists sayfasında da çevirebilirim.

@alioguzhan alioguzhan self-requested a review May 2, 2023 15:38
alioguzhan
alioguzhan requested changes May 2, 2023
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesekkurler. Bazi yerleri belirttim. Uzerlerine konusabiliriz isterseniz. Sonrasinda merge edebiliriz.

@alioguzhan
Copy link
Member

alioguzhan commented May 2, 2023

bir de, bir satirda conflict var sanirim. upstreamden guncelleme gelmisti bu dosyaya. onlar cakisiyor sanirim.

@github-actions
Copy link

github-actions bot commented May 3, 2023 •
edited
Loading

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@serkanisyapan
Copy link
Contributor Author

serkanisyapan commented May 3, 2023

bir de, bir satirda conflict var sanirim. upstreamden guncelleme gelmisti bu dosyaya. onlar cakisiyor sanirim.

Teşekkürler, gerekli değişiklikleri yaptım. Conflict sorununu da çözdüm sanırım. Bu konularda yeniyim bir yanlışlık olmamıştır umarım.

alioguzhan
alioguzhan approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesekkurler. Conflict de cozulmus gozukuyor. Merge ediyorum

@alioguzhan alioguzhan merged commit b2554b3 into reactjs:main May 3, 2023
@alioguzhan alioguzhan mentioned this pull request May 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alioguzhan alioguzhan alioguzhan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serkanisyapan @alioguzhan