Second edition is now the definitive edition#1180
Merged
carols10cents merged 2 commits intomasterfrom Feb 21, 2018
Merged
Conversation
* Remove warning about draft from second edition * Add warning about first edition draft being older * Change overview page to better state today's situation
phil-opp
reviewed
Feb 21, 2018
index.md
Outdated
|
|
||
| ### First Edition | ||
|
|
||
| YOu can [read the first edition of "The Rust Programming Language" |
carols10cents
approved these changes
Feb 21, 2018
Member
carols10cents
left a comment
carols10cents
left a comment
There was a problem hiding this comment.
LGTM, built the first and second editions locally and everything looked as i would expect. It's a bit hard to test the rustbuild stuff and the links; could you send a pr to rust to get this into nightly so we can make sure that part works soon?
Member
|
fancy, trying out leaving the tab open to see if github merges when travis succeeds |
Contributor
Author
I was planning on doing it right after the merge :) |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 21, 2018
This updates the book repository, but mostly to include rust-lang/book#1180 TL;DR: the second edition is close enough to done that we should universally recommend it over the first edition.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2018
…best-edition, r=QuietMisdreavus Update the book to promote second edition This updates the book repository, but mostly to include rust-lang/book#1180 TL;DR: the second edition is close enough to done that we should universally recommend it over the first edition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @carols10cents