Don't use .cargo for custom CARGO_HOME#1148
Conversation
Users changing cargo's home directory expect it to be used as top path instead of there being a `.cargo` hidden dir in it. There are some cases following this pattern one of them is python's virtualenvwrapper, which uses `WORK_HOME` as a home dir for everything. This patch removes the extra `.cargo` and assumes that CARGO_HOME is the real path a user wants to use as a homedir for cargo.
|
@brson r? |
|
I think we need @alexcrichton's review here. |
|
👍 |
|
(Aren't we meant to be using the XDG variables by default per #148 as well?) |
|
@huonw My only concern is that for Servo, we need to be able to not write any files outside of the enlistment directory. |
|
@larsbergstrom, yeah, that would only be the default (rather than |
|
I think the order of precedence we would have (in theory) would be:
Which is to say that I think we can still fit in the XDG specification here. |
|
⌛ Testing commit bef8095 with merge b9a80db... |
|
💔 Test failed - cargo-win-64 |
|
@bors: retry |
|
⌛ Testing commit bef8095 with merge ed06187... |
|
💔 Test failed - cargo-win-64 |
|
@bors: retry |
Users changing cargo's home directory expect it to be used as top path instead of there being a `.cargo` hidden dir in it. There are some cases following this pattern one of them is python's virtualenvwrapper, which uses `WORK_HOME` as a home dir for everything. This patch removes the extra `.cargo` and assumes that CARGO_HOME is the real path a user wants to use as a homedir for cargo.
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
6 participants
Users changing cargo's home directory expect it to be used as top path
instead of there being a
.cargohidden dir in it. There are some casesfollowing this pattern one of them is python's virtualenvwrapper, which
uses
WORKON_HOMEas a home dir for everything.This patch removes the extra
.cargoand assumes that CARGO_HOME is thereal path a user wants to use as a homedir for cargo.