Pass --edition after --crate-name#7710
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 16, 2019
dtolnay:argorder
Merged
Pass --edition after --crate-name#7710bors merged 1 commit intorust-lang:masterfrom dtolnay:argorder
bors merged 1 commit intorust-lang:masterfrom
dtolnay:argorder
Conversation
This PR swaps the order of the --edition and --crate-name args in the
rustc invocation.
Before: rustc --edition=2018 --crate-name cargo ...
After: rustc --crate-name cargo --edition=2018 ...
The crate name is a lot more relevant when looking at processes in top
for example, and should appear first.
Member
|
@bors: r+ |
Contributor
|
📌 Commit 9aa65c5 has been approved by |
bors
added
the
S-waiting-on-bors
Contributor
bors
added a commit
that referenced
this pull request
Dec 16, 2019
Pass --edition after --crate-name This PR swaps the order of the --edition and --crate-name args in the rustc invocation. - Before: `rustc --edition=2018 --crate-name cargo ...` - After: `rustc --crate-name cargo --edition=2018 ...` The crate name is a lot more relevant when looking at processes in `top` for example, and should appear first.
Contributor
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR swaps the order of the --edition and --crate-name args in the rustc invocation.
rustc --edition=2018 --crate-name cargo ...rustc --crate-name cargo --edition=2018 ...The crate name is a lot more relevant when looking at processes in
topfor example, and should appear first.