Document that OUT_DIR in JSON messages is an absolute path#8403
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 24, 2020
Merged
Document that OUT_DIR in JSON messages is an absolute path#8403bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Eh2406
reviewed
Jun 24, 2020
| /* An absolute path which is used as a value of `OUT_DIR` environmental | ||
| variable when compiling current package. | ||
| */ | ||
| "out_dir": "/some/path/in/target/dir" |
Contributor
There was a problem hiding this comment.
Should this example line be changed to look more like an absolute path?
Contributor
Author
There was a problem hiding this comment.
It starts with a / already, so that should be fine I think.
Contributor
|
@bors r+ |
Contributor
|
📌 Commit 39c1081 has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 39c1081 with merge c7e8663614366bf1f0bfd5010e002e60020f5745... |
Contributor
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Member
|
@bors: retry |
bors
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 39c1081 with merge 526ea90f2c7e051e0c3264e6cbc97ffd90f51d00... |
Contributor
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Member
|
@bors: retry |
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-azure |
Contributor
Author
|
So apparently sometimes OUT_DIR is an empty string: rust-lang/rust-analyzer#5125 (comment) Does this sound like a Cargo bug? |
Member
|
Reading over the code I don't think it's possible for |
Contributor
Author
|
Mystery solved, it is cargo metadata which helpfully sets default value: https://github.com/oli-obk/cargo_metadata/blob/f9d8073c90e2a9254af290313d9118bbeb5fc179/src/messages.rs#L81 |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 2, 2020
Update cargo ## cargo 10 commits in c26576f9adddd254b3dd63aecba176434290a9f6..305eaf0dc5f5a38d6e8041319c2da95b71cf6a4a 2020-06-23 16:21:21 +0000 to 2020-06-30 14:16:08 +0000 - Update core-foundation requirement from 0.7.0 to 0.9.0 (rust-lang/cargo#8432) - Parse `# env-dep` directives in dep-info files (rust-lang/cargo#8421) - Move string interning to util (rust-lang/cargo#8419) - Expose built cdylib artifacts in the Compilation structure (rust-lang/cargo#8418) - Remove unused serde_derive dependency from the crates.io crate (rust-lang/cargo#8416) - Remove unused remove_dir_all dependency (rust-lang/cargo#8412) - Improve git error messages a bit (rust-lang/cargo#8409) - Improve the description of Config.home_path (rust-lang/cargo#8408) - Improve support for non-`master` main branches (rust-lang/cargo#8364) - Document that OUT_DIR in JSON messages is an absolute path (rust-lang/cargo#8403) ## rls 2020-06-19 15:36:00 +0200 to 2020-06-30 23:34:52 +0200 - Update cargo (rust-lang/rls#1686)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 3, 2020
Update cargo, rls ## cargo 14 commits in c26576f9adddd254b3dd63aecba176434290a9f6..fede83ccf973457de319ba6fa0e36ead454d2e20 2020-06-23 16:21:21 +0000 to 2020-07-02 21:51:34 +0000 - Fix overflow error on 32-bit. (rust-lang/cargo#8446) - Exclude the target directory from backups using CACHEDIR.TAG (rust-lang/cargo#8378) - CONTRIBUTING.md: Link to Zulip rather than Discord (rust-lang/cargo#8436) - Update built-in help for features (rust-lang/cargo#8433) - Update core-foundation requirement from 0.7.0 to 0.9.0 (rust-lang/cargo#8432) - Parse `# env-dep` directives in dep-info files (rust-lang/cargo#8421) - Move string interning to util (rust-lang/cargo#8419) - Expose built cdylib artifacts in the Compilation structure (rust-lang/cargo#8418) - Remove unused serde_derive dependency from the crates.io crate (rust-lang/cargo#8416) - Remove unused remove_dir_all dependency (rust-lang/cargo#8412) - Improve git error messages a bit (rust-lang/cargo#8409) - Improve the description of Config.home_path (rust-lang/cargo#8408) - Improve support for non-`master` main branches (rust-lang/cargo#8364) - Document that OUT_DIR in JSON messages is an absolute path (rust-lang/cargo#8403) ## rls 2020-06-19 15:36:00 +0200 to 2020-06-30 23:34:52 +0200 - Update cargo (rust-lang/rls#1686)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.