Clarify fingerprint log messages#9026
Merged
bors merged 2 commits intorust-lang:masterfrom Dec 29, 2020
Merged
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Thank you! |
Contributor
|
📌 Commit 4538ade has been approved by |
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 7, 2021
Update cargo 12 commits in 75d5d8cffe3464631f82dcd3c470b78dc1dda8bb..329895f5b52a358e5d9ecb26215708b5cb31d906 2020-12-22 18:10:56 +0000 to 2021-01-06 00:01:52 +0000 - metadata: Supply local path for path dependencies (rust-lang/cargo#8994) - Add support for Rust edition 2021. (rust-lang/cargo#8922) - Stabilize -Zfeatures and -Zpackage-features. (rust-lang/cargo#8997) - Small refactor, adding a list of all kinds to BuildContext (rust-lang/cargo#9046) - Fix git http.proxy config setting. (rust-lang/cargo#8986) - Clarify the help text of `--aggressive` and `--precise` of `update` (rust-lang/cargo#9031) - Assert that tests are run in the crate directory (rust-lang/cargo#9037) - Update mdbook (rust-lang/cargo#9044) - Bump to 0.52.0, update changelog (rust-lang/cargo#9042) - Fix redundant semicolon. (rust-lang/cargo#9033) - Clarify fingerprint log messages (rust-lang/cargo#9026) - Update credential docs for gnome-secret. (rust-lang/cargo#9013)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2021
Update cargo 12 commits in 75d5d8cffe3464631f82dcd3c470b78dc1dda8bb..329895f5b52a358e5d9ecb26215708b5cb31d906 2020-12-22 18:10:56 +0000 to 2021-01-06 00:01:52 +0000 - metadata: Supply local path for path dependencies (rust-lang/cargo#8994) - Add support for Rust edition 2021. (rust-lang/cargo#8922) - Stabilize -Zfeatures and -Zpackage-features. (rust-lang/cargo#8997) - Small refactor, adding a list of all kinds to BuildContext (rust-lang/cargo#9046) - Fix git http.proxy config setting. (rust-lang/cargo#8986) - Clarify the help text of `--aggressive` and `--precise` of `update` (rust-lang/cargo#9031) - Assert that tests are run in the crate directory (rust-lang/cargo#9037) - Update mdbook (rust-lang/cargo#9044) - Bump to 0.52.0, update changelog (rust-lang/cargo#9042) - Fix redundant semicolon. (rust-lang/cargo#9033) - Clarify fingerprint log messages (rust-lang/cargo#9026) - Update credential docs for gnome-secret. (rust-lang/cargo#9013)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to look up the source to figure out which side was the old value for a RUSTFLAGS fingerprint mismatch.
Making the logs a bit more explicit about which value is old and new would've helped me.