redox: convert to target_family unix#1332
Conversation
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
|
@jackpot51 I think it would be better to make the rust-lang/rust PR use the libc of this branch, and once bors try passes there, then we can merge this here, release, and update the rust-lang/rust PR to use the released version, and merge it with high priority. What do you think? |
|
I think that sounds good to me. I will do that soon |
|
@gnzlbg it is done: rust-lang/rust#60547, rust-lang/rust@2ab50af |
|
@bors: r+ |
|
📌 Commit eb75c48 has been approved by |
redox: convert to target_family unix This is the first step to supporting rust-lang/rust#60139. In order to have a smooth transition, there will need to be a change made in rust at the same time, switching Redox over to the unix target family. See rust-lang/rust#60547
|
So let's merge this, do a release, and then you can update the PR upstream ! |
|
💔 Test failed - checks-travis |
|
@gnzlbg what should I do about the build failure? I checked and the failures do not seem to be introduced by this PR, but am open to including fixes if possible and necessary. |
|
It's #1333 The thing is upgrading system on CI is not trivial task for this repo because the code is verified against the system. |
|
@bors: r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit eb75c48 has been approved by |
redox: convert to target_family unix This is the first step to supporting rust-lang/rust#60139. In order to have a smooth transition, there will need to be a change made in rust at the same time, switching Redox over to the unix target family. See rust-lang/rust#60547
|
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
|
Woohoo! |
redox: convert to target_family unix This is the second step to supporting #60139. In order to have a smooth transition, there will need to be a change made in liblibc at the same time, switching Redox over to the unix target family. See rust-lang/libc#1332
5 participants
This is the first step to supporting rust-lang/rust#60139.
In order to have a smooth transition, there will need to be a change made in rust at the same time, switching Redox over to the unix target family. See rust-lang/rust#60547