musl: enable getrandom on all musl platforms#4346
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Mar 22, 2025
tamird:musl-getrandom
Merged
musl: enable getrandom on all musl platforms#4346tgross35 merged 1 commit intorust-lang:mainfrom tamird:musl-getrandom
getrandom on all musl platforms#4346tgross35 merged 1 commit intorust-lang:mainfrom
tamird:musl-getrandom
Conversation
The existing bindings were added in #1399 and limited to targets where rustc used musl version >= 1.1.20 which was not all musl targets at that time. Since rust-lang/rust#107129 all musl targets use musl 1.2.3. Hence, move the binding to the module root so it is available for all musl targets.
Collaborator
1 task
This was referenced Mar 26, 2025
Closed
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 3, 2025
The existing bindings were added in rust-lang#1399 and limited to targets where rustc used musl version >= 1.1.20 which was not all musl targets at that time. Since rust-lang/rust#107129 all musl targets use musl 1.2.3. Hence, move the binding to the module root so it is available for all musl targets. (backport <rust-lang#4346>) (cherry picked from commit 77d3011)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The existing bindings were added in #1399 and limited to targets where
rustc used musl version >= 1.1.20 which was not all musl targets at that
time. Since rust-lang/rust#107129 all musl
targets use musl 1.2.3. Hence, move the binding to the module root so it
is available for all musl targets.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI