Conversation
carols10cents
approved these changes
Apr 5, 2017
Member
carols10cents
left a comment
There was a problem hiding this comment.
I don't have r here, but lgtm!
Contributor
|
Thanks! |
Contributor
incidentally, how did you notice this? Did you try to update the submodule yourself? |
Contributor
Author
|
@steveklabnik |
This was referenced Dec 1, 2018
mark-i-m
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Dec 1, 2018
This happens every time a new doc submodule is added to https://github.com/rust-lang/rust. cc rust-lang/book#549 rust-lang/reference#36 rust-lang/rust-by-example#1018
bors bot
added a commit
to rust-embedded/book
that referenced
this pull request
Feb 10, 2019
127: Fix failing tidy (line endings on Windows) r=japaric a=petrochenkov This happens every time a new doc submodule is added to https://github.com/rust-lang/rust. cc rust-lang/book#549 rust-lang/reference#36 rust-lang/rust-by-example#1018 rust-lang/rustc-dev-guide#246 Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is exactly the same issue as rust-lang/book#549,
x.py test src/tools/tidyis failing again.r? @steveklabnik @carols10cents