RFC for creation of IntoRaw{Fd, Socket, Handle} trait to complement AsRaw*

[ipetkov]

Rendered

[ipetkov]

cc @alexcrichton @aturon

[sfackler]

I like the idea of this functionality, but I'd go with Into<RawFd> etc instead of defining new traits. The common convention is to both implement Into<Foo> and add an into_foo() method to a type, since Into is useful in a generic context but can be a bit of a pain to use if you have a concrete TcpStream or whatever that has multiple Into impls.

[alexcrichton]

Unfortunately using Into<RawFd> means that when you convert an object to a file descriptor there's no platform-specific opt-in, you instead just call let a: i32 = file.into() and it becomes a portability hazard. In having separate traits you acknowledge the platform-specific-ness via use std::os::unix::....

[sfackler]

Ah, yeah, that makes sense. I'm on board with IntoRaw{Fd,Handle,Socket} then.

[l0kod]

👍

[alexcrichton]

This RFC is now entering its week-long final comment period.

[alexcrichton]

The consensus of the libs team this week is to merge this RFC, so I'm going to do so. Thanks again for the RFC @ipetkov!

Tracking issue