Replace #2603's (Rust Symbol Mangling) "v2" with "v0".#2879
Merged
nikomatsakis merged 1 commit intomasterfrom Apr 8, 2020
Merged
Replace #2603's (Rust Symbol Mangling) "v2" with "v0".#2879nikomatsakis merged 1 commit intomasterfrom
nikomatsakis merged 1 commit intomasterfrom
Conversation
Centril
added
the
not-rfc
Contributor
|
Seems fine. |
nikomatsakis
approved these changes
Apr 8, 2020
Contributor
|
This will impact the URL of https://rust-lang.github.io/rfcs/2603-symbol-name-mangling-v2.html -- but I don't know to what extent we expect those links to be truly "permanent". (I've always wished those links only had the RFC number, so that they were more "guessable" if nothing else.) |
Contributor
|
I'm just going to merge it =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #2603 was implemented, we decided on these names (rust-lang/rust#57967 (comment)):
legacy, for the pre-RFC: Rust Symbol Mangling (v0) #2603 mangling based on the Itanium C++ onev0, for the RFC: Rust Symbol Mangling (v0) #2603 manglingThat differs from the RFC, so I've renamed away the "v2" in the RFC title (#2603 (comment)) and the tracking issue (rust-lang/rust#60705 (comment)), and that leaves the file itself.
cc @rust-lang/compiler