Add 0000-vecdeque-binary-search.md: Binary search fns for VecDeque#2997
Closed
vojtechkral wants to merge 1 commit intorust-lang:masterfrom
Closed
Add 0000-vecdeque-binary-search.md: Binary search fns for VecDeque#2997vojtechkral wants to merge 1 commit intorust-lang:masterfrom
vojtechkral wants to merge 1 commit intorust-lang:masterfrom
Conversation
scottmcm
added
the
T-libs-api
Member
I agree, and as such I think you can just submit it as a PR. This would be an inherent method, thus can be stabilization gated, and there are no API questions since it's just following the existing precedent. (The more general version would probably be setting new precedents -- for example, we only have sort on slices, not general iterators -- so that one would probably have more value in being an RFC.) But of course I'm not on libs so you can always wait and see what they say. |
5 tasks
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Oct 17, 2020
… r=scottmcm,dtolnay liballoc: VecDeque: Add binary search functions I am submitting rust-lang/rfcs#2997 as a PR as suggested by @scottmcm I haven't yet created a tracking issue - if there's a favorable feedback I'll create one and update the issue links in the unstable attribs.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Oct 17, 2020
… r=scottmcm,dtolnay liballoc: VecDeque: Add binary search functions I am submitting rust-lang/rfcs#2997 as a PR as suggested by @scottmcm I haven't yet created a tracking issue - if there's a favorable feedback I'll create one and update the issue links in the unstable attribs.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 3, 2021
…=m-ou-se Stabilize `vecdeque_binary_search` This PR stabilizes the feature `vecdeque_binary_search` as tracked in rust-lang#78021. The tracking issue has not received any comments for the past 5 months, and concerns have been raised neither in the RFC rust-lang/rfcs#2997 nor in the tracking issue rust-lang#78021.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 3, 2021
…=m-ou-se Stabilize `vecdeque_binary_search` This PR stabilizes the feature `vecdeque_binary_search` as tracked in rust-lang#78021. The tracking issue has not received any comments for the past 5 months, and concerns have been raised neither in the RFC rust-lang/rfcs#2997 nor in the tracking issue rust-lang#78021.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Internals topic