Conversation
|
@matthewjasper could you have a look at this? Specifically the "fix categorizations" commit, I'm not sure if that's the right fix for the cases that were recursively looping Also, I'm not sure where I should be getting an infcx from, |
matthewjasper
left a comment
matthewjasper
left a comment
There was a problem hiding this comment.
Also, I'm not sure where I should be getting an infcx from,
tcx.infer_ctxt(|| { ... })?
tcx.infer_ctxt().enter(|| { ... })
clippy_lints/src/escape.rs
Outdated
| fn consume(&mut self, cmt: &cmt_<'tcx>, mode: ConsumeMode) { | ||
| if let Categorization::Local(lid) = cmt.cat { | ||
| fn consume(&mut self, cmt: &Place<'tcx>, mode: ConsumeMode) { | ||
| if let PlaceBase::Local(lid) = cmt.base { |
There was a problem hiding this comment.
In this file there should also be a check that cmt.projections is empty.
There was a problem hiding this comment.
I just added it to every method of the EUV. It didn't break anything, so I think this should be ok?
flip1995
added
the
S-waiting-on-review
|
@bors r=matthewjasper,oli-obk |
|
📌 Commit 604e6ba has been approved by |
Rustup From rust-lang/rust#66246 changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
5 participants
From rust-lang/rust#66246
changelog: none