Error on duplicate matcher bindings#57617
Conversation
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Code LGTM, needs green Travis for crater. |
6189852 to
0de49cf
Compare
|
As with #57610, I have been getting a seeming unrelated ICE. I tried rebasing, so hopefully this should be passing now. It's also worthwhile to note that we had breakage in rustc's own test suite, which I fixed in the last commit... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The rebase solved the previous issue, but there was another test that needed to be updated. |
|
@petrochenkov This looks like its passing locally. Perhaps we can |
|
@bors try |
|
⌛ Trying commit 5b700955fb0d5c5656731f7bd722260f6dfee85b with merge 0bfb90d213a93e466b33d078a5b535a2a6f9c5ff... |
|
☀️ Test successful - checks-travis |
|
@craterbot run start=master#e2f221c75932de7a29845c8d6f1f73536ad00c41 end=try#0bfb90d213a93e466b33d078a5b535a2a6f9c5ff mode=check-only |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
|
The 4 fixed appear to be spurious un-failures. There are two regressions:
|
|
@mark-i-m |
|
@mark-i-m Could you also reach out to the Seems like we should be able to turn this into a hard error pretty quickly. |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
☔ The latest upstream changes (presumably #58125) made this pull request unmergeable. Please resolve the merge conflicts. |
684d4fa to
c25d6b8
Compare
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
|
@Centril could you remove the "waiting-for-team" tag please? |
|
@bors r+ |
|
📌 Commit c25d6b8 has been approved by |
…nkov Error on duplicate matcher bindings fix #57593 This should not be merged without a crater run and maybe an FCP. Discussion is ongoing at #57593. TODO: - [x] write tests - [x] crater run - [x] ~maybe need edition gating?~ not for 1 regression /centril r? @petrochenkov
|
☀️ Test successful - checks-travis, status-appveyor |
|
@Centril should this be mentioned in release notes? |
|
@mark-i-m I think we usually do that when it becomes an actual hard error, but I'm not sure... cc @nikomatsakis re. that... |
fix #57593
This should not be merged without a crater run and maybe an FCP. Discussion is ongoing at #57593.
TODO:
maybe need edition gating?not for 1 regression /centrilr? @petrochenkov